PackageLicenseExpression, PackageProjectUrl .csproj addition #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: I noticed a Directory.Build.props file is new in one of the other branches (https://github.com/redis/NRedisStack/tree/marc/build-cleanup) that I suspect will make its way to master, eventually. It's normal enough for these two properties to be listed in the Directory.Build.props file instead, if it's of interest, but it's probably fine either way. |
Merged
|
Closing as already covered by #431 |
|
Closing as already covered by #431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My company's code analysis security software (Aikido) complains that the licensing for the NRedisStack nuget package is unclear. To help my company and other companies like us resolve the citation, I kindly request/suggest the project's MIT license be set in the NuGet package properties via a PackageLicenseExpression tag as so. I added the PackageProjectUrl as well, while I was at it, to help quickly link developers to the repo from the NuGet package explorer in Visual Studio.
When I opened the .csproj file, it was a mix of tabs and spaces, and I wasn't sure which convention was preferable. I saw vague indication spaces were the precedent, so I rationalized the existing tabs into spaces and indented the tags accordingly. Note that most VS installations use tabs for .csproj files by default, so that might be why/how tabs ended up being added. Surely let me know if tabs are preferred instead, and/or if I should go about resolving this citation in general another way. Thanks!